Demonstrate test failure with go-data-transfer v1.7.8 #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#615 is failing CI to a test related to cancelling data transfers. The failure is regular and appears on a local test run.
However, this issue is triggered by changes in go-data-transfer 1.7.8, which changes something with the cancelling process (see filecoin-project/go-data-transfer#245).
This PR just demonstrates the failure occurs by updated to 1.7.8 and nothing else. (the tests pass on v1.7.7 FWIW)
Previously, go-fil-markets was on 1.7.6. The go-graphsync update PR was not triggering the issue until now because it wasn't rebased on go-data-transfer master.
I'm not sure the intent of the changes in 1.7.8 so I'm not sure the best way this test should be fixed.